Refactor inputs (#823)

Don't load at import time and make it easier to test

__tests__/download/manifest.test.ts

@@ -17,7 +17,6 @@ const {
   fetchManifest,
   getAllVersions,
   getArtifact,
-  getLatestVersion,
   parseManifest,
 } = await import("../../src/download/manifest");
 

__tests__/utils/inputs.test.ts

@@ -1,3 +1,6 @@
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
 import {
   afterEach,
   beforeEach,
@@ -7,9 +10,13 @@ import {
   jest,
 } from "@jest/globals";
 
-// Will be mutated per test before (re-)importing the module under test
 let mockInputs: Record<string, string> = {};
+const tempDirs: string[] = [];
 const ORIGINAL_HOME = process.env.HOME;
+const ORIGINAL_RUNNER_ENVIRONMENT = process.env.RUNNER_ENVIRONMENT;
+const ORIGINAL_RUNNER_TEMP = process.env.RUNNER_TEMP;
+const ORIGINAL_UV_CACHE_DIR = process.env.UV_CACHE_DIR;
+const ORIGINAL_UV_PYTHON_INSTALL_DIR = process.env.UV_PYTHON_INSTALL_DIR;
 
 const mockDebug = jest.fn();
 const mockGetBooleanInput = jest.fn(
@@ -27,118 +34,228 @@ jest.unstable_mockModule("@actions/core", () => ({
   warning: mockWarning,
 }));
 
-async function importInputsModule() {
-  return await import("../../src/utils/inputs");
+const { CacheLocalSource, loadInputs } = await import("../../src/utils/inputs");
+
+function createTempProject(files: Record<string, string>): string {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), "setup-uv-inputs-test-"));
+  tempDirs.push(dir);
+
+  for (const [relativePath, content] of Object.entries(files)) {
+    const filePath = path.join(dir, relativePath);
+    fs.mkdirSync(path.dirname(filePath), { recursive: true });
+    fs.writeFileSync(filePath, content);
+  }
+
+  return dir;
 }
 
+function resetEnvironment(): void {
+  jest.clearAllMocks();
+  mockInputs = {};
+  process.env.HOME = "/home/testuser";
+  delete process.env.RUNNER_ENVIRONMENT;
+  delete process.env.RUNNER_TEMP;
+  delete process.env.UV_CACHE_DIR;
+  delete process.env.UV_PYTHON_INSTALL_DIR;
+}
+
+function restoreEnvironment(): void {
+  while (tempDirs.length > 0) {
+    const dir = tempDirs.pop();
+    if (dir !== undefined) {
+      fs.rmSync(dir, { force: true, recursive: true });
+    }
+  }
+
+  process.env.HOME = ORIGINAL_HOME;
+  process.env.RUNNER_ENVIRONMENT = ORIGINAL_RUNNER_ENVIRONMENT;
+  process.env.RUNNER_TEMP = ORIGINAL_RUNNER_TEMP;
+  process.env.UV_CACHE_DIR = ORIGINAL_UV_CACHE_DIR;
+  process.env.UV_PYTHON_INSTALL_DIR = ORIGINAL_UV_PYTHON_INSTALL_DIR;
+}
+
+beforeEach(() => {
+  resetEnvironment();
+});
+
+afterEach(() => {
+  restoreEnvironment();
+});
+
+describe("loadInputs", () => {
+  it("loads defaults for a github-hosted runner", () => {
+    mockInputs["working-directory"] = "/workspace";
+    mockInputs["enable-cache"] = "auto";
+    process.env.RUNNER_ENVIRONMENT = "github-hosted";
+    process.env.RUNNER_TEMP = "/runner-temp";
+
+    const inputs = loadInputs();
+
+    expect(inputs.enableCache).toBe(true);
+    expect(inputs.cacheLocalPath).toEqual({
+      path: "/runner-temp/setup-uv-cache",
+      source: CacheLocalSource.Default,
+    });
+    expect(inputs.pythonDir).toBe("/runner-temp/uv-python-dir");
+    expect(inputs.venvPath).toBe("/workspace/.venv");
+    expect(inputs.manifestFile).toBeUndefined();
+    expect(inputs.resolutionStrategy).toBe("highest");
+  });
+
+  it("uses cache-dir from pyproject.toml when present", () => {
+    mockInputs["working-directory"] = createTempProject({
+      "pyproject.toml": `[project]
+name = "uv-project"
+version = "0.1.0"
+
+[tool.uv]
+cache-dir = "/tmp/pyproject-toml-defined-cache-path"
+`,
+    });
+
+    const inputs = loadInputs();
+
+    expect(inputs.cacheLocalPath).toEqual({
+      path: "/tmp/pyproject-toml-defined-cache-path",
+      source: CacheLocalSource.Config,
+    });
+    expect(mockInfo).toHaveBeenCalledWith(
+      expect.stringContaining("Found cache-dir in"),
+    );
+  });
+
+  it("uses UV_CACHE_DIR from the environment", () => {
+    mockInputs["working-directory"] = createTempProject({});
+    process.env.UV_CACHE_DIR = "/env/cache-dir";
+
+    const inputs = loadInputs();
+
+    expect(inputs.cacheLocalPath).toEqual({
+      path: "/env/cache-dir",
+      source: CacheLocalSource.Env,
+    });
+    expect(mockInfo).toHaveBeenCalledWith(
+      "UV_CACHE_DIR is already set to /env/cache-dir",
+    );
+  });
+
+  it("uses UV_PYTHON_INSTALL_DIR from the environment", () => {
+    mockInputs["working-directory"] = "/workspace";
+    process.env.UV_PYTHON_INSTALL_DIR = "/env/python-dir";
+
+    const inputs = loadInputs();
+
+    expect(inputs.pythonDir).toBe("/env/python-dir");
+    expect(mockInfo).toHaveBeenCalledWith(
+      "UV_PYTHON_INSTALL_DIR is already set to /env/python-dir",
+    );
+  });
+
+  it("warns when parsing a malformed pyproject.toml for cache-dir", () => {
+    mockInputs["working-directory"] = createTempProject({
+      "pyproject.toml": `[project]
+name = "malformed-pyproject-toml-project"
+version = "0.1.0"
+
+[malformed-toml
+`,
+    });
+
+    const inputs = loadInputs();
+
+    expect(inputs.cacheLocalPath).toBeUndefined();
+    expect(mockWarning).toHaveBeenCalledWith(
+      expect.stringContaining("Error while parsing pyproject.toml:"),
+    );
+  });
+
+  it("throws for an invalid resolution strategy", () => {
+    mockInputs["working-directory"] = "/workspace";
+    mockInputs["resolution-strategy"] = "middle";
+
+    expect(() => loadInputs()).toThrow(
+      "Invalid resolution-strategy: middle. Must be 'highest' or 'lowest'.",
+    );
+  });
+});
+
 describe("cacheDependencyGlob", () => {
-  beforeEach(() => {
-    jest.resetModules();
-    jest.clearAllMocks();
-    mockInputs = {};
-    process.env.HOME = "/home/testuser";
-  });
-
-  afterEach(() => {
-    process.env.HOME = ORIGINAL_HOME;
-  });
-
-  it("returns empty string when input not provided", async () => {
+  it("returns empty string when input not provided", () => {
     mockInputs["working-directory"] = "/workspace";
-    const { cacheDependencyGlob } = await importInputsModule();
-    expect(cacheDependencyGlob).toBe("");
+
+    const inputs = loadInputs();
+
+    expect(inputs.cacheDependencyGlob).toBe("");
   });
 
-  it("resolves a single relative path", async () => {
+  it.each([
+    ["requirements.txt", "/workspace/requirements.txt"],
+    ["./uv.lock", "/workspace/uv.lock"],
+  ])("resolves %s to %s", (globInput, expected) => {
     mockInputs["working-directory"] = "/workspace";
-    mockInputs["cache-dependency-glob"] = "requirements.txt";
-    const { cacheDependencyGlob } = await importInputsModule();
-    expect(cacheDependencyGlob).toBe("/workspace/requirements.txt");
+    mockInputs["cache-dependency-glob"] = globInput;
+
+    const inputs = loadInputs();
+
+    expect(inputs.cacheDependencyGlob).toBe(expected);
   });
 
-  it("strips leading ./ from relative path", async () => {
-    mockInputs["working-directory"] = "/workspace";
-    mockInputs["cache-dependency-glob"] = "./uv.lock";
-    const { cacheDependencyGlob } = await importInputsModule();
-    expect(cacheDependencyGlob).toBe("/workspace/uv.lock");
-  });
-
-  it("handles multiple lines, trimming whitespace, tilde expansion and absolute paths", async () => {
+  it("handles multiple lines, trimming whitespace, tilde expansion and absolute paths", () => {
     mockInputs["working-directory"] = "/workspace";
     mockInputs["cache-dependency-glob"] =
       "  ~/.cache/file1\n ./rel/file2  \nfile3.txt";
-    const { cacheDependencyGlob } = await importInputsModule();
-    expect(cacheDependencyGlob).toBe(
+
+    const inputs = loadInputs();
+
+    expect(inputs.cacheDependencyGlob).toBe(
       [
-        "/home/testuser/.cache/file1", // expanded tilde, absolute path unchanged
-        "/workspace/rel/file2", // ./ stripped and resolved
-        "/workspace/file3.txt", // relative path resolved
+        "/home/testuser/.cache/file1",
+        "/workspace/rel/file2",
+        "/workspace/file3.txt",
       ].join("\n"),
     );
   });
 
-  it("keeps absolute path unchanged in multiline input", async () => {
-    mockInputs["working-directory"] = "/workspace";
-    mockInputs["cache-dependency-glob"] = "/abs/path.lock\nrelative.lock";
-    const { cacheDependencyGlob } = await importInputsModule();
-    expect(cacheDependencyGlob).toBe(
+  it.each([
+    [
+      "/abs/path.lock\nrelative.lock",
       ["/abs/path.lock", "/workspace/relative.lock"].join("\n"),
-    );
-  });
-
-  it("handles exclusions in relative paths correct", async () => {
-    mockInputs["working-directory"] = "/workspace";
-    mockInputs["cache-dependency-glob"] = "!/abs/path.lock\n!relative.lock";
-    const { cacheDependencyGlob } = await importInputsModule();
-    expect(cacheDependencyGlob).toBe(
+    ],
+    [
+      "!/abs/path.lock\n!relative.lock",
       ["!/abs/path.lock", "!/workspace/relative.lock"].join("\n"),
-    );
+    ],
+  ])("normalizes multiline glob %s", (globInput, expected) => {
+    mockInputs["working-directory"] = "/workspace";
+    mockInputs["cache-dependency-glob"] = globInput;
+
+    const inputs = loadInputs();
+
+    expect(inputs.cacheDependencyGlob).toBe(expected);
   });
 });
 
 describe("tool directories", () => {
-  beforeEach(() => {
-    jest.resetModules();
-    jest.clearAllMocks();
-    mockInputs = {};
-    process.env.HOME = "/home/testuser";
-  });
-
-  afterEach(() => {
-    process.env.HOME = ORIGINAL_HOME;
-  });
-
-  it("expands tilde for tool-bin-dir and tool-dir", async () => {
+  it("expands tilde for tool-bin-dir and tool-dir", () => {
     mockInputs["working-directory"] = "/workspace";
     mockInputs["tool-bin-dir"] = "~/tool-bin-dir";
     mockInputs["tool-dir"] = "~/tool-dir";
 
-    const { toolBinDir, toolDir } = await importInputsModule();
+    const inputs = loadInputs();
 
-    expect(toolBinDir).toBe("/home/testuser/tool-bin-dir");
-    expect(toolDir).toBe("/home/testuser/tool-dir");
+    expect(inputs.toolBinDir).toBe("/home/testuser/tool-bin-dir");
+    expect(inputs.toolDir).toBe("/home/testuser/tool-dir");
   });
 });
 
 describe("cacheLocalPath", () => {
-  beforeEach(() => {
-    jest.resetModules();
-    jest.clearAllMocks();
-    mockInputs = {};
-    process.env.HOME = "/home/testuser";
-  });
-
-  afterEach(() => {
-    process.env.HOME = ORIGINAL_HOME;
-  });
-
-  it("expands tilde in cache-local-path", async () => {
+  it("expands tilde in cache-local-path", () => {
     mockInputs["working-directory"] = "/workspace";
     mockInputs["cache-local-path"] = "~/uv-cache/cache-local-path";
 
-    const { CacheLocalSource, cacheLocalPath } = await importInputsModule();
+    const inputs = loadInputs();
 
-    expect(cacheLocalPath).toEqual({
+    expect(inputs.cacheLocalPath).toEqual({
       path: "/home/testuser/uv-cache/cache-local-path",
       source: CacheLocalSource.Input,
     });
@@ -146,63 +263,37 @@ describe("cacheLocalPath", () => {
 });
 
 describe("venvPath", () => {
-  beforeEach(() => {
-    jest.resetModules();
-    jest.clearAllMocks();
-    mockInputs = {};
-    process.env.HOME = "/home/testuser";
-  });
-
-  afterEach(() => {
-    process.env.HOME = ORIGINAL_HOME;
-  });
-
-  it("defaults to .venv in the working directory", async () => {
+  it("defaults to .venv in the working directory", () => {
     mockInputs["working-directory"] = "/workspace";
-    const { venvPath } = await importInputsModule();
-    expect(venvPath).toBe("/workspace/.venv");
+
+    const inputs = loadInputs();
+
+    expect(inputs.venvPath).toBe("/workspace/.venv");
   });
 
-  it("resolves a relative venv-path", async () => {
+  it.each([
+    ["custom-venv", "/workspace/custom-venv"],
+    ["custom-venv/", "/workspace/custom-venv"],
+    ["/tmp/custom-venv", "/tmp/custom-venv"],
+    ["~/.venv", "/home/testuser/.venv"],
+  ])("resolves venv-path %s to %s", (venvPathInput, expected) => {
     mockInputs["working-directory"] = "/workspace";
     mockInputs["activate-environment"] = "true";
-    mockInputs["venv-path"] = "custom-venv";
-    const { venvPath } = await importInputsModule();
-    expect(venvPath).toBe("/workspace/custom-venv");
+    mockInputs["venv-path"] = venvPathInput;
+
+    const inputs = loadInputs();
+
+    expect(inputs.venvPath).toBe(expected);
   });
 
-  it("normalizes venv-path with trailing slash", async () => {
-    mockInputs["working-directory"] = "/workspace";
-    mockInputs["activate-environment"] = "true";
-    mockInputs["venv-path"] = "custom-venv/";
-    const { venvPath } = await importInputsModule();
-    expect(venvPath).toBe("/workspace/custom-venv");
-  });
-
-  it("keeps an absolute venv-path unchanged", async () => {
-    mockInputs["working-directory"] = "/workspace";
-    mockInputs["activate-environment"] = "true";
-    mockInputs["venv-path"] = "/tmp/custom-venv";
-    const { venvPath } = await importInputsModule();
-    expect(venvPath).toBe("/tmp/custom-venv");
-  });
-
-  it("expands tilde in venv-path", async () => {
-    mockInputs["working-directory"] = "/workspace";
-    mockInputs["activate-environment"] = "true";
-    mockInputs["venv-path"] = "~/.venv";
-    const { venvPath } = await importInputsModule();
-    expect(venvPath).toBe("/home/testuser/.venv");
-  });
-
-  it("warns when venv-path is set but activate-environment is false", async () => {
+  it("warns when venv-path is set but activate-environment is false", () => {
     mockInputs["working-directory"] = "/workspace";
     mockInputs["venv-path"] = "custom-venv";
 
-    const { activateEnvironment, venvPath } = await importInputsModule();
+    const inputs = loadInputs();
 
-    expect(activateEnvironment).toBe(false);
-    expect(venvPath).toBe("/workspace/custom-venv");
+    expect(inputs.activateEnvironment).toBe(false);
+    expect(inputs.venvPath).toBe("/workspace/custom-venv");
     expect(mockWarning).toHaveBeenCalledWith(
       "venv-path is only used when activate-environment is true",
     );